Fix error in tartype_by_suffix()

Found by Wolfgang Gehrhardt

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Fix collect_project regression

Make collect_project work with init files again. A regression test
has been added.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

create next changelog entry

Signed-off-by: Tobias Ulmer <tu@emlix.com>

release e2factory-2.3.14

Signed-off-by: Tobias Ulmer <tu@emlix.com>

create next changelog entry

Signed-off-by: Tobias Ulmer <tu@emlix.com>

release e2factory-2.3.14rc1

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Hash the result name.

The result name is passed into the build chroot as environment variable.
To prevent the same build ids for results that are equal in all but the
name, the name must be considered when calculating the build id.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove hardcoded base chroot group from collect_project

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Require tools module, fixes trace building in wc-mode

Signed-off-by: Tobias Ulmer <tu@emlix.com>

create next changelog entry

Signed-off-by: Tobias Ulmer <tu@emlix.com>

release e2factory-2.3.13

Signed-off-by: Tobias Ulmer <tu@emlix.com>

create next changelog entry

Signed-off-by: Tobias Ulmer <tu@emlix.com>

release e2factory-2.3.13rc5

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Repair e2lib.islocaltool(), look at the right place

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove regexp matching for manpages

Pretty silly, seems to be a left-over from a previous iteration of the
code.

In addition, don't mention anything about sections as there is no
support for matching them (yet). We do not have manpages with the same
name in both sections, so it's not a problem for now.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

manpages: bug-fixes

create next changelog entry

Signed-off-by: Tobias Ulmer <tu@emlix.com>

release e2factory-2.3.13rc4

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Repair interrupt_hook() call from signal handler

Also ignore signal while interrupt_hook() is running, to prevent
cleanup from being interrupted.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

create next changelog entry

Signed-off-by: Tobias Ulmer <tu@emlix.com>

release e2factory-2.3.13rc3

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Respect $EDITOR

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add git url support to git plugin

Suggested by patch from CADCON

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add http, https and svn url support to svn plugin

Suggested by a patch from CADCON

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Revert "use the tools module instead of hardcoding chown"

This reverts commit 52571c840e035bf9abc4e724b453001ce7abca8d.

External tools and tools inside the chroot are different beasts. Revert
my commit as this was plain wrong.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

create next changelog entry

Signed-off-by: Tobias Ulmer <tu@emlix.com>

release e2factory-2.3.13rc2

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add XZ support for sources

This depends on a tar version in the chroot that supports xz archives.

The code has been restructured such that we don't play guessing games
based on the magic number in the file header anmore, and just go by
extension. Also, since all this extraction business is only relevant to
file sources, move it into the files plugin instead of cluttering e2lib.

To be clear, this change removes the questionable feature of detecting
that a .tar.bz2 tarball was really a .tar.gz and will instead return an
error message by he way of tar failing.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Cleanup templates, fix formating, add modelines

Also remove a few lesser used keys, they can be looked up in the manual.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove outdated comment

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove outdated bits about the documentation

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Cleanup release process information a bit.

These days it's pretty much streamlined into release.sh

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Polish the extensions README a bit

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Point to an existing manual page

Signed-off-by: Tobias Ulmer <tu@emlix.com>

On glibc, strerror_r does not do what you think it does...

Fixes empty error messages in various places.

glibc will use the GNU version of strerror_r by default, which does not
fill the buffer but rather uses it as a temporary storage space. It
returns a pointer to the error string, which was never used.

Since e2 is not multithreaded, replace it with the simpler strerror()
and remove pointless casts.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Export licenceid() function

Required by files plugin.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Move check_licence() so it is declared on use

Signed-off-by: Tobias Ulmer <tu@emlix.com>

create next changelog entry

Signed-off-by: Tobias Ulmer <tu@emlix.com>

release e2factory-2.3.13rc1

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove trailing slash from git urls, assembla.com can't handle it

While there, make generic_git.git_clone_url1() local and clean up a bit.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Touch up developer documentation and code little

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Document more info fields, clean umask and local_init a bit

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Return false instead of nil in locate_project_root()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove outdated comments

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Document info.local_template_path field

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Introduce e2-cf to source and result groups...

Add a large dose of error checking.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove slashToDot() and export two replacements

Results/source names can now reliably be converted into a file system
path or into e2factory group notation using
e2tool.src_res_name_to_path() and e2tool.src_res_path_to_name()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Clarify and limit valid src/res paths and names

Backwards compatibility change ahead:

Disallow result and source pathnames that contain a dot (.) as this is
an endless source of pain. Dots may now only be used to group results
and sources. This makes reliable translation from file paths to result
groups and back possible.

Rename the functions doing the validation, add documentation, and make
them available outside of the e2tool module. Improve error messages.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Don't limit slashToDot() to 100 replacements

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove generatePath(), drop postfix param in resultdir() etc

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Switch --help over to display the man page of the tool

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add basic ldoc comments, just to get an overview

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Install e2 and e2-help man pages

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add e2-help man page

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Install e2-help as a local tool

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add e2-help, makes it easier to view e2 documentation

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add manpage for e2

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Improve plugin module documentation

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Repair error propagation from sub-makes

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Clean up git.check_workingcopy(), improve error handling

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Improve read_line doc and return a sensible error message

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove e2lib.e2_su()

The tool does not exist any more, remove the function call as well.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Cast argv to the right pointer type

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Drop unused variable rc

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove warning when hardlinking fails

Also remove bogus error catenation. Link failures will still be logged
by the kernel, but they are harmless.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add files to ignore on newly created projects.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove e2option.documentation

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Make sure new-source gets the correct number of arguments

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Rename arg in e2lib.parse_server_location(), add assert

arg is used as a hidden parameter by Lua.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2: call usage() with the proper exit code

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add tools.isinitialized()

Return whether the tools module still needs to be initialized or not.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

tools: add "man" tool.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Undeclared field access is ok unless field is a string.

strict does not have the ability to declare fields like arr[1]. Until
functionality is added that allows this, disable the fatal error for all
non-string types.

Also fix up a couple of comments.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib: add isglobaltool() and isglocaltool()

A tool may also be neither global nor local. An example would be "e2"
itself.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Move defaultoptions() and userdefaultoptions() out of parse()

Makes it clear that nothing fancy is going on, these are just factored
out for clarity.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove e2lib.chomp() and e2lib.read_configuration()

Both are unused.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add (minimal) documentation to all e2lib functions

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Convert locate_project_root() documentation to ldoc.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add e2lib.cleanup(), to be called before we exit e2.

Deduplicates code that needs to run before we exit the e2 process.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Buildid change: remove workaround to keep buildid identical

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Buildid change: stop indiscriminately hashing the "base" group

Fixes a stacktrace when using a chroot config default group different to
"base". This fix causes a buildid change, since the invalid base group
was hashed into the result buildid.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

doc: fix makefiles

man-page, e2source: improve description of attribute "copy", fixes bugzilla 34

documentation: remove the outdated mark-down-based docs

man-pages: adopt Makefiles to new man-pages

man-pages: Create/rework tool related manpages

man-pages: add a newline at end of file to allow full display

man-pages: Create/rework config-file related manpages and e2factory head manpage

Remove example directory, outdated

There are plans to revive the examples as more full-featured but
separate project.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove unused e2lib.read_all() and fix documentation

Signed-off-by: Tobias Ulmer <tu@emlix.com>

remove unused skip_checkout variable

Signed-off-by: Tobias Ulmer <tu@emlix.com>

remove e2lib.program_output() and inline its only user

Signed-off-by: Tobias Ulmer <tu@emlix.com>

fetch-sources: do checkout files after cloning a new source

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Rework howtounpack() and friends to fix shell quoting.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

tools: add function to get the tool name

Signed-off-by: Tobias Ulmer <tu@emlix.com>

use e2lib.logf()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Improve update source error message by including the source name

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Rewrite and fix e2source copy handling.

Add consistent and sensible behavior for the copy option. Share code
with the function having to do the same operation for collect_project.
While there, add LDoc comments.

Repairs trac bugs #1003 and #1019.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Generate help for all functions.

Ldoc will otherwise filter out local functions.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Repair dirname and basename

basename and dirname must be able to handle paths ending in zero or more
slashes. Concatenation of dir- and basename will otherwise go wrong in
edge cases.

previously:
dirname(foo/bar/) -> foo/bar
basename(foo/bar/) -> bar
=> foo/bar/bar

now:
dirname(foo/bar///) -> foo
basename(foo/bar///) -> bar
=> foo/bar

Signed-off-by: Tobias Ulmer <tu@emlix.com>