Document e2tool.dsort()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Document e2tool.dlist_recursive() and clarify the code

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Improve documentation, mostly error cases

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove nil in return and error statements

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove some left over error handling

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Don't use stdio to deal with pipes.

Buffering and attempts to loop until a buffer is filled make it
a pain to work with.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

eio: add read, write and close, return file descriptor from pipe()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add read, write, and close wrapers

Stdio only works well with regular files. For pipes, the native syscalls
work much better.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Plug small memory leak in case of poll error

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Reduce and refine tracing a bit

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Fix collect_project, add missing info.cache argument

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Adjust callcmd() to the new poll() interface

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Change and extend e2lib.poll() interface

Instead of a single pos in the fdvec table, return a table of all
selected file descriptors. Allows handling more than one active file
descriptor in one go.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Check whether symlink exists, not the destination

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Synchronise parent/child in callcmd()

Prevent poll() from running before all file descriptors are set up
and debug logging is disabled in the child.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Fix call to warnf() without category

The warning about optional tools can be a WHINT, no need to complain all
the time about something that is optional.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Fix use after free in poll

Been there since the beginning of (e2factory) time.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Disable write buffering on pipe file object

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add eio.setunbuffered()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Turn collect_project feature into a plugin

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Allow calling e2build.write_build_driver()

Useful for plugins.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

environment: add tofile function

tofile() creates a shell-sourceable file containing the environment.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove documentation for export field in result

Can't find a reference to it anywhere.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

info.ftab should be private to e2tool

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove select_result() and merge code with select_results()

No functional change.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Make load_source_config() plural and add documentation

Reflect that this function loads all source configs into the info table.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Make load_result_config() plural and add documentation

Reflect that this function loads all result configs into the info table.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Make e2tool.get_depends() local, e2tool.dlist should be used instead

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2build: Get dependencies via the extendable e2tool.dlist

I can't see a reason why it's calling e2tool.get_depends directly.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove missleading and unused info.build_mode

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove missleading and unused info.build_modes

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add ldoc comment todo markers, make them show up at least

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Enable optimization

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Explicitly require and use the cache module

cache metatable is gone.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Cache: remove metatable and clean up

 * Remove meta table, forcing grep-able code
 * Mark cache table fields private
 * lock cache and cache entry tables
 * Consistently return false on errors
 * Turn ce_by_server() into a dict table lookup

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Clean up projid()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

info.servers doesn't seem to exist any more, remove

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Fix typo

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove dead code

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Integrate hashcache into hash module

Use hash_file_once() most everywhere. Hashcache keeps track of number of
cache hits and limits the cache to the 1000 most used.

It's also much more strict in what is considered a match.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2tool: Remove hash_path() and use hash.hash_file_once instead

Signed-off-by: Tobias Ulmer <tu@emlix.com>

hash: Add hash_file_once() which does all the hash context work

Signed-off-by: Tobias Ulmer <tu@emlix.com>

tools: Remove tools that are no longer called directly

sha1sum, md5sum, cat, uname, and bzip2

Signed-off-by: Tobias Ulmer <tu@emlix.com>

transport: Fix wrong documentation for file_path()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

transport: in fetch_file, improve doc and remove strange tmp path splitting

Signed-off-by: Tobias Ulmer <tu@emlix.com>

cache: transport.fetch_file does not take a flags argument

Signed-off-by: Tobias Ulmer <tu@emlix.com>

git: cosmetic cleanup

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2tool: Convert to absolute paths and remove e2tool.lcd()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2-cf: Use absolute paths everywhere

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2build: Remove all chdir() games and deal with absolute paths only

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2tool: extend resultdir(), sourceconfig() and friends by an optional prefix

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add workdir argument to svn_tool() and use it

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Extend e2lib.call_tool_argv() with optional workdir and envdict args

Both are passed to callcmd()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Correct write_extension_config() doc comment

Signed-off-by: Tobias Ulmer <tu@emlix.com>

fetch-project: Fix absolute destination paths

Bug introduced in 6d3d6f5de9c9667c4e679909b2a34590a89c18bb on
Thu Oct 31 21:29:36 2013 +0100. Didn't make it into a release.
A testcase has been created for this problem.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Stop changing directory in e2-install-e2

Signed-off-by: Tobias Ulmer <tu@emlix.com>

No need for chdir in fetch-project

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Read/write global_interface_version_file from an absolute path

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Define syntax_file global and use it

Removes another static field from the info table.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Use e2lib.parse_e2versionfile() instead of hand-rolled code

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Extend e2lib.read_extension_config()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Provide global for e2version file and use it

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Provide global for project-location and use it

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2-create-project: use absolute paths instead of chdir

Signed-off-by: Tobias Ulmer <tu@emlix.com>

parse_server_location: improve doc, lock table, fix return errors

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Massage e2.conf searching/parsing into a single function.

Move read_global_config() into e2lib.get_global_config().

Collapse reading of .e2/e2config into get_global_config(). Remove need for
e2lib.globals.cmdline vector which was only used to pass --e2-config
around. Remove e2lib.sete2config() which used to set the E2_CONFIG
environment variable for calling another e2 tool.

In e2-fetch-project, pass arg vector to e2-install-e2. Previously this
relied on E2_CONFIG being set. Now all arguments, --e2-config, warning
flags and verbosity options are passed along.

The returned config table is locked to detect errors.

Update ldoc comments while cleaning up.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Format option and flag dicts

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Fix typos in warning flags, clarify

Update copyright year while there.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Lock e2lib.globals table and clean up variables

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove unused variable LUA_ALL_VERSIONS

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Replace os.execute() with e2lib.callcmd()

No more shell string concatenation and quoting...

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2-cf: use callcmd to start editor

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Simplify man viewer execution

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Delete unused debug and playground globals

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Try to make --log-debug documentation less confusing

This is a developer option with limited use to the general user. It
makes it possible to see at which warning or log level a message is sent
to the console.

This information is also available in debug.log, thus this option is more
or less obsolete. Too bad it's documented already...

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove dead code: e2lib.getlogflags()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

do_execvp: Allocate space for the terminating NULL pointer

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Use console module everywhere

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib: open console as soon as possible and close it last

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib: add doc comments for warn/warnf

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Prevent module loading loop between e2lib, eio and console

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add console module

All IO to the console should go through this module from now on.
Read the LDoc comments for details.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2-dlist: fix format string for invalid result

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2-dlist: repair crash on error, include err module

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove the now unused e2lib.callcmd_pipe()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Directly checkout or copy instead of using callcmd_pipe with tar

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Use ssh_remote_cmd() to remotely calculate the checksum

Use digest.parsestring() to split the output instead of some ad-hoc
matching. This concludes the removal of io.popen().

Signed-off-by: Tobias Ulmer <tu@emlix.com>

digest: add parsestring() function, rewrite internals

The old digest matcher could not handle spaces in filenames. Write a
better parser that can handle these, and error out on escaped digests (which
should be pretty rare).

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Extend e2lib.ssh_remote_cmd() to capture and return stdout

Easy with the new callcmd()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Deal with chrootgroupid() errors and remove dead code

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2build: use eio

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2-playground: use eio

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Use eio for writing hashcache

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Write debuglogfile using eio

Signed-off-by: Tobias Ulmer <tu@emlix.com>

plugins: convert Makefile generation to eio

While there, call the "makefile" "Makefile", like everyone else

Signed-off-by: Tobias Ulmer <tu@emlix.com>

digest: use eio to write digest file

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2: replace shell string construction and quoting with callcmd()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Mark rc/256 as construct specific to os.execute

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2option: showtoolmanpage() does return, handle return code correctly

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add return of terminating signal in e2lib.wait()

Signed-off-by: Tobias Ulmer <tu@emlix.com>