Add getter/setter for info table

Doesn't have to be passed as an argument everywhere.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Don't pass main string package into protected environment

The string package can easily be manipulated or variable passed around
in it. Supply each protected environment with its own copy of the
table and only add functions that are considered safe.

Invert resultid/pbuildid ftab error signaling mechanism

Error is now signaled by either false or nil, true to skip and
checksum for everything else. Improve the callback function names for
debug.log and traces. Add documentation all round.

This makes callbacks behave like every other function, instead of a
loaded gun pointing at foot...

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Improve e2tool check_results() doc

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Allow returning error from e2tool.dlist()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Missed return false to error() conversion

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove some locals

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Split chroot config into own module and class

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove unused load functions in load_user_config2()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Initialize the cache early

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove info.chroot.groups and clean up

info.chroot.group_byname contains the same groups. Merge duplicate
documentation, lock most chroot tables, consistently use ipairs().

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Simplify chroot setup by dropping build_config.groups

Use chroot groups of the result instead of going through
build_config.groups. Make sure res.chroot is sorted independent of
proj/chroot.

Previously we did a complicated dance adding all required groups to a
build_config dict and then iterated over the entire chroot table. The
order in which chroot groups were untared did depend on the order of
appearance in proj/chroot.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Change pcall to e2lib.trycall, a wrapper with more debug information

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Whoops, the -f in git checkout was missing

Works so much better now...

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Log all external commands at debug level

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add missed return false on error

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Make dofile2() more strict, improving config file error detection

The capability to disallow global variables and reading undefined
variables in configs existed for a long time but was not enabled for
most files... Implements bz#127

Signed-off-by: Tobias Ulmer <tu@emlix.com>

LicenceID includes the licence name

Makes no sense to hash it twice. Fixes bz#124

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Create licence class and move all licence handling into own module

In addition to all the motions of moving licence out of e2tool, the
following bugs should be fixed in this commit:

svn plugin: Fix bz#123, include LicenceID in SourceID calculation
cvs plugin: Fix bz#126, backtrace when calculating LicenceID

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add or move generic table/attribute verification functions to e2lib

Signed-off-by: Tobias Ulmer <tu@emlix.com>

install class.lua

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add ldoc header for middleclass

Signed-off-by: Tobias Ulmer <tu@emlix.com>

add middleclass

Signed-off-by: Tobias Ulmer <tu@emlix.com>

strict: point error to the stack frame where it occurred

Signed-off-by: Tobias Ulmer <tu@emlix.com>

files: error out if the unpack location doesn't exist after unpacking

A mistake here leads to a confusing error message that is by itself
correct, but hard to understand for the user.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Run e2 tools in protected mode, allowing for use of error()

Convert the top level error handling to error(). Not buying us much as
of now, but it's a start.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Move check_project_info into collect_project_info

The distinction makes little sense now, since collect_project_info also
does a lot of checking.

One less step for local tools required

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove a couple of chroot fields that don't exist any more

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Only 6 X are replaced in by mktemp... functions, shorten

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Document rsync version requirement

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Cleanup collect_project, document, add pbuildid fn...

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2tool: Remove remnants of collect_project

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Move collect_project resultid calculation out of e2tool

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add note about what return values resultid() expects

Signed-off-by: Tobias Ulmer <tu@emlix.com>

There is no r.pseudo_result field anywhere...

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Document e2tool.dsort()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Document e2tool.dlist_recursive() and clarify the code

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Improve documentation, mostly error cases

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove nil in return and error statements

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove some left over error handling

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Don't use stdio to deal with pipes.

Buffering and attempts to loop until a buffer is filled make it
a pain to work with.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

eio: add read, write and close, return file descriptor from pipe()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add read, write, and close wrapers

Stdio only works well with regular files. For pipes, the native syscalls
work much better.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Plug small memory leak in case of poll error

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Reduce and refine tracing a bit

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Fix collect_project, add missing info.cache argument

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Adjust callcmd() to the new poll() interface

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Change and extend e2lib.poll() interface

Instead of a single pos in the fdvec table, return a table of all
selected file descriptors. Allows handling more than one active file
descriptor in one go.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Check whether symlink exists, not the destination

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Synchronise parent/child in callcmd()

Prevent poll() from running before all file descriptors are set up
and debug logging is disabled in the child.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Fix call to warnf() without category

The warning about optional tools can be a WHINT, no need to complain all
the time about something that is optional.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Fix use after free in poll

Been there since the beginning of (e2factory) time.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Disable write buffering on pipe file object

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add eio.setunbuffered()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Turn collect_project feature into a plugin

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Allow calling e2build.write_build_driver()

Useful for plugins.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

environment: add tofile function

tofile() creates a shell-sourceable file containing the environment.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove documentation for export field in result

Can't find a reference to it anywhere.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

info.ftab should be private to e2tool

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove select_result() and merge code with select_results()

No functional change.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Make load_source_config() plural and add documentation

Reflect that this function loads all source configs into the info table.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Make load_result_config() plural and add documentation

Reflect that this function loads all result configs into the info table.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Make e2tool.get_depends() local, e2tool.dlist should be used instead

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2build: Get dependencies via the extendable e2tool.dlist

I can't see a reason why it's calling e2tool.get_depends directly.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove missleading and unused info.build_mode

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove missleading and unused info.build_modes

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add ldoc comment todo markers, make them show up at least

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Enable optimization

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Explicitly require and use the cache module

cache metatable is gone.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Cache: remove metatable and clean up

 * Remove meta table, forcing grep-able code
 * Mark cache table fields private
 * lock cache and cache entry tables
 * Consistently return false on errors
 * Turn ce_by_server() into a dict table lookup

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Clean up projid()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

info.servers doesn't seem to exist any more, remove

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Fix typo

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove dead code

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Integrate hashcache into hash module

Use hash_file_once() most everywhere. Hashcache keeps track of number of
cache hits and limits the cache to the 1000 most used.

It's also much more strict in what is considered a match.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2tool: Remove hash_path() and use hash.hash_file_once instead

Signed-off-by: Tobias Ulmer <tu@emlix.com>

hash: Add hash_file_once() which does all the hash context work

Signed-off-by: Tobias Ulmer <tu@emlix.com>

tools: Remove tools that are no longer called directly

sha1sum, md5sum, cat, uname, and bzip2

Signed-off-by: Tobias Ulmer <tu@emlix.com>

transport: Fix wrong documentation for file_path()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

transport: in fetch_file, improve doc and remove strange tmp path splitting

Signed-off-by: Tobias Ulmer <tu@emlix.com>

cache: transport.fetch_file does not take a flags argument

Signed-off-by: Tobias Ulmer <tu@emlix.com>

git: cosmetic cleanup

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2tool: Convert to absolute paths and remove e2tool.lcd()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2-cf: Use absolute paths everywhere

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2build: Remove all chdir() games and deal with absolute paths only

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2tool: extend resultdir(), sourceconfig() and friends by an optional prefix

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add workdir argument to svn_tool() and use it

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Extend e2lib.call_tool_argv() with optional workdir and envdict args

Both are passed to callcmd()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Correct write_extension_config() doc comment

Signed-off-by: Tobias Ulmer <tu@emlix.com>

fetch-project: Fix absolute destination paths

Bug introduced in 6d3d6f5de9c9667c4e679909b2a34590a89c18bb on
Thu Oct 31 21:29:36 2013 +0100. Didn't make it into a release.
A testcase has been created for this problem.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Stop changing directory in e2-install-e2

Signed-off-by: Tobias Ulmer <tu@emlix.com>

No need for chdir in fetch-project

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Read/write global_interface_version_file from an absolute path

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Define syntax_file global and use it

Removes another static field from the info table.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Use e2lib.parse_e2versionfile() instead of hand-rolled code

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Extend e2lib.read_extension_config()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Provide global for e2version file and use it

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Provide global for project-location and use it

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2-create-project: use absolute paths instead of chdir

Signed-off-by: Tobias Ulmer <tu@emlix.com>

parse_server_location: improve doc, lock table, fix return errors

Signed-off-by: Tobias Ulmer <tu@emlix.com>