Remove unused variable LUA_ALL_VERSIONS

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Replace os.execute() with e2lib.callcmd()

No more shell string concatenation and quoting...

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2-cf: use callcmd to start editor

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Simplify man viewer execution

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Delete unused debug and playground globals

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Try to make --log-debug documentation less confusing

This is a developer option with limited use to the general user. It
makes it possible to see at which warning or log level a message is sent
to the console.

This information is also available in debug.log, thus this option is more
or less obsolete. Too bad it's documented already...

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove dead code: e2lib.getlogflags()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

do_execvp: Allocate space for the terminating NULL pointer

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Use console module everywhere

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib: open console as soon as possible and close it last

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib: add doc comments for warn/warnf

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Prevent module loading loop between e2lib, eio and console

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add console module

All IO to the console should go through this module from now on.
Read the LDoc comments for details.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2-dlist: fix format string for invalid result

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2-dlist: repair crash on error, include err module

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove the now unused e2lib.callcmd_pipe()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Directly checkout or copy instead of using callcmd_pipe with tar

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Use ssh_remote_cmd() to remotely calculate the checksum

Use digest.parsestring() to split the output instead of some ad-hoc
matching. This concludes the removal of io.popen().

Signed-off-by: Tobias Ulmer <tu@emlix.com>

digest: add parsestring() function, rewrite internals

The old digest matcher could not handle spaces in filenames. Write a
better parser that can handle these, and error out on escaped digests (which
should be pretty rare).

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Extend e2lib.ssh_remote_cmd() to capture and return stdout

Easy with the new callcmd()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Deal with chrootgroupid() errors and remove dead code

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2build: use eio

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2-playground: use eio

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Use eio for writing hashcache

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Write debuglogfile using eio

Signed-off-by: Tobias Ulmer <tu@emlix.com>

plugins: convert Makefile generation to eio

While there, call the "makefile" "Makefile", like everyone else

Signed-off-by: Tobias Ulmer <tu@emlix.com>

digest: use eio to write digest file

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2: replace shell string construction and quoting with callcmd()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Mark rc/256 as construct specific to os.execute

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2option: showtoolmanpage() does return, handle return code correctly

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add return of terminating signal in e2lib.wait()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Sync hash module with lsha1 changes, improve documentation and error handling

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Simplify lsha1.c and bring it in line with leio and le2lib

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Don't hard-code make, but fetch the command from buildconfig

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add sha1 to list of 3RDPARTY sources

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Handle sourceset2ref errors correctly

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Document generic_git.sourceset2ref(), improve error reporting

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2-new-source: generic_git.new_repository() has no flags argument any more

Signed-off-by: Tobias Ulmer <tu@emlix.com>

generic_git: Remove usage markers and unused flags argument

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Improve callcmd()/fdct documentation

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove e2lib.sha1sum() in favor of the hash module

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Use hash module to calculate sha1 sum

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Adjust to get_tool_flags() change, convert back to string where required

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2-install-e2: Remove shell quoting

Signed-off-by: Tobias Ulmer <tu@emlix.com>

digest: Improve developer docs

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2-fetch-project: Remove shell quoting

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2build: Remove shell quoting and prepare an arg vector

Signed-off-by: Tobias Ulmer <tu@emlix.com>

generic_git.git(): Remove shell string construction

Signed-off-by: Tobias Ulmer <tu@emlix.com>

CVS: Vectorize arguments and call new cvs_tool()

Lots of crummy code removed and refactored.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

tools.get_tool_flags(): Return vector of flags instead of string

Adds a parser so users don't have to change their e2.conf. The parser
handles single and double quote strings as well as \\ and \" escapes.

Allows converting all tool calls to argv without loss of functionality.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

tools.check_tool(): Use argv

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove e2lib.cat(), which was yet another way to do simple IO...

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add doc hint to mv and cp functions

Signed-off-by: Tobias Ulmer <tu@emlix.com>

call_tool_argv(): No more shell string construction

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove call_tool(), call_tool_argv() is the new king

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Use the digest module instead of call_tool and sha1sum

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Fix e2lib.execvp() doc

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Introduce elib.callcmd() with more flexibility

Commands can now be passed as argument vectors straight into execvp().
This removes all shell quoting headaches when going through this
interface.
File descriptors can be set up in a table-driven way as necessary.
A workdir for the child can be set. Environment variables can be
supplied now.

All callcmd friends are either removed or converted to this interface
with the exception of callcmd_pipe().

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove shell command constructs from git.toresult()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Improve error reporting in e2lib.setenv()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Implement e2lib.execvp()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Move patch() into files plugin and convert to argv

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib.cp: change flags to recursive and use an argv

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Initialize shift, gcc complains because the conditions are a little twisted

Disable do_unsetenv() for now, silences gcc complaints

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Inline callcmd() in callcmd_pipe() in order to remove later

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Correct e2lib.poll() documentation

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Repair error reporting in e2lib.wait()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Improve eio error messages, keep the file name/fd around

Signed-off-by: Tobias Ulmer <tu@emlix.com>

eio.fread() now requires a size

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Use eio in hash_file()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add "size" argument to eio.fread()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Replace shell command mktemp with a mkstemp() call.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Provide mkstemp() wrapper

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Replace shell command mktemp -d with a mkdtemp() call.

One more io.popen() is gone.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add mkdtemp() wrapper.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

lib is an array, dereferencing it for a pointer is wrong.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

isdigit() is declared in ctype.h, include it

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Replace popen() with callcmd_capture() and require missing err module.

Due to pure luck, nobody ran into a code path using err yet...

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Stop accessing private hash context fields, call hash functions via module

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Mark the hash context fields private, force calls to go through module

Make it possible to grep for calls and change the implementation.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Fix crash on MD5 checksum entry

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Convert digest.parse() to eio

Use digest functions to construct digest table and entries.
Fix a file descriptor leak.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove unused global env table

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove global interactive flag

Was probably once used to enter a debug mode. Since that's no more,
axe the variable.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

We don't use hostname for anything, remove the code

Another io.popen call bites the dust.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Could not find out what use the "mmm" sourceset is, remove it

Introduced in 53183d030127937d41a5bf211b22255cd4991eec, without a single
reference anywhere, nor explanation why sourceset would be "mmm"...

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Include PID in trace logging

Surprisingly no measurable increase in run time

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Extend trace module to allow for filtering

Attempt to reduce the debug.log noise by filtering the err module
warnf/logf calls and others.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Move e2lib.svn() into the SVN plugin

Signed-off-by: Tobias Ulmer <tu@emlix.com>

git_init_db1(): remove default behaviour, require a choice

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove e2lib.git comment

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Merge git_new_argv2() into generic_git.git_new_argv()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove e2lib.git() for good

Signed-off-by: Tobias Ulmer <tu@emlix.com>

All generic_git.git_rev_list1() users are gone, delete it

Signed-off-by: Tobias Ulmer <tu@emlix.com>

In git.check_workingcopy(), use lookup_id to find the branch

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Sync fetch_source with fetch-project, use lookup_id and clean up

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Overhaul git.update() making use of the work in generic_git

Update does not create merge commits any more. This change requires a
git version supporting git merge --ff-only. Tested with version 1.6.6.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

git.git_commit_id(): use lookup_id() function

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Use absolute GIT_DIR path, decouple errors from dirty/mismatch flag

Signed-off-by: Tobias Ulmer <tu@emlix.com>