Improve plugin module documentation

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Repair error propagation from sub-makes

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Clean up git.check_workingcopy(), improve error handling

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Improve read_line doc and return a sensible error message

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove e2lib.e2_su()

The tool does not exist any more, remove the function call as well.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Cast argv to the right pointer type

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Drop unused variable rc

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove warning when hardlinking fails

Also remove bogus error catenation. Link failures will still be logged
by the kernel, but they are harmless.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add files to ignore on newly created projects.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove e2option.documentation

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Make sure new-source gets the correct number of arguments

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Rename arg in e2lib.parse_server_location(), add assert

arg is used as a hidden parameter by Lua.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2: call usage() with the proper exit code

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add tools.isinitialized()

Return whether the tools module still needs to be initialized or not.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

tools: add "man" tool.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Undeclared field access is ok unless field is a string.

strict does not have the ability to declare fields like arr[1]. Until
functionality is added that allows this, disable the fatal error for all
non-string types.

Also fix up a couple of comments.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib: add isglobaltool() and isglocaltool()

A tool may also be neither global nor local. An example would be "e2"
itself.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Move defaultoptions() and userdefaultoptions() out of parse()

Makes it clear that nothing fancy is going on, these are just factored
out for clarity.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove e2lib.chomp() and e2lib.read_configuration()

Both are unused.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add (minimal) documentation to all e2lib functions

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Convert locate_project_root() documentation to ldoc.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add e2lib.cleanup(), to be called before we exit e2.

Deduplicates code that needs to run before we exit the e2 process.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Buildid change: remove workaround to keep buildid identical

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Buildid change: stop indiscriminately hashing the "base" group

Fixes a stacktrace when using a chroot config default group different to
"base". This fix causes a buildid change, since the invalid base group
was hashed into the result buildid.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

doc: fix makefiles

man-page, e2source: improve description of attribute "copy", fixes bugzilla 34

documentation: remove the outdated mark-down-based docs

man-pages: adopt Makefiles to new man-pages

man-pages: Create/rework tool related manpages

man-pages: add a newline at end of file to allow full display

man-pages: Create/rework config-file related manpages and e2factory head manpage

Remove example directory, outdated

There are plans to revive the examples as more full-featured but
separate project.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove unused e2lib.read_all() and fix documentation

Signed-off-by: Tobias Ulmer <tu@emlix.com>

remove unused skip_checkout variable

Signed-off-by: Tobias Ulmer <tu@emlix.com>

remove e2lib.program_output() and inline its only user

Signed-off-by: Tobias Ulmer <tu@emlix.com>

fetch-sources: do checkout files after cloning a new source

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Rework howtounpack() and friends to fix shell quoting.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

tools: add function to get the tool name

Signed-off-by: Tobias Ulmer <tu@emlix.com>

use e2lib.logf()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Improve update source error message by including the source name

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Rewrite and fix e2source copy handling.

Add consistent and sensible behavior for the copy option. Share code
with the function having to do the same operation for collect_project.
While there, add LDoc comments.

Repairs trac bugs #1003 and #1019.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Generate help for all functions.

Ldoc will otherwise filter out local functions.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Repair dirname and basename

basename and dirname must be able to handle paths ending in zero or more
slashes. Concatenation of dir- and basename will otherwise go wrong in
edge cases.

previously:
dirname(foo/bar/) -> foo/bar
basename(foo/bar/) -> bar
=> foo/bar/bar

now:
dirname(foo/bar///) -> foo
basename(foo/bar///) -> bar
=> foo/bar

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add more smarts to the tracer() function.

Detects binary strings and sorts out functions based on the C module
(which does not give useful information anyway). Do not log return from
functions. All this speeds up my tests by 7%.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Explicitly load e2util module in e2lib

It's a C module, so it does not share the strict loading requirements of
the new Lua modules. Load it explicitly, otherwise many functions in
e2lib will terminate with a backtrace unless another module loaded
e2util before.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove store-run-log server

This was presumably used to log e2 command usage internally to ease
debugging in the early stage of e2factory. It's not needed anymore.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove e2-build-numbers command.

This tool has not been in use for years. So now is the time to remove
it.  For backwards compatibility, the symlink is still installed, and a
small replacement tool prints out an error message, should anyone try to
use it.

The server component can go away as well.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

repair bomb() calls

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Partial rewrite of e2-new-source

Lots of bug fixes and improved error messages.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Install digest module

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add digest, a message digest handling module.

Digest allows creation, verification, computation, parsing and writing
message digest as created and read by sha1sum and similar programs.
Currently MD5 support is incomplete (need MD5 module first).

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add e2lib.join(), a function that joins path components

Inspired by Python's os.path.join

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Fix typos

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add module descriptions and fix small ldoc errors

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Generate developer docs with our local ldoc

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Import luafilesystem 1.6.2

https://github.com/downloads/keplerproject/luafilesystem/luafilesystem-1.6.2.tar.gz

Import Penlight, a dependency of LDoc

https://github.com/stevedonovan/Penlight/
git ref: b8e56fffb6 tag: 1.0.2

Import LDoc 1.2.0

https://github.com/stevedonovan/LDoc/
git ref: 9bf51e3294 tag: 1.2.0

Clean up pathname operations

* document dirname() in luadoc style
* document basename() in luadoc style. Drop the optional extension
  stripping capability, since nothing seems to use it.
* there are no users of splitpath(), drop it.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

local/e2-new-source.lua: check if file is already on the server

If we try to create a new source, using the "--files" parameter
then we now check if a file with the same name is already on the
server.

Before this patch, it was possible to overwrite an existing file
without any notifications.

e2-new-source aborts now if a file with the same name already exists.

Signed-off-by: Fabian Godehardt <fg@emlix.com>

local/e2-new-source.lua: make sure curl can return an error value on file download

Signed-off-by: Fabian Godehardt <fg@emlix.com>

e2build: abort if there is a non regular file in proj/init

Signed-off-by: Fabian Godehardt <fg@emlix.com>

cvs: quote revision tag properly

Signed-off-by: Fabian Godehardt <fg@emlix.com>

e2lib.tar() takes an argument vector

Signed-off-by: Fabian Godehardt <fg@emlix.com>

svn: use scm.generic_source_check()

Signed-off-by: Fabian Godehardt <fg@emlix.com>

build.sh: do not attempt to copy nonexisting files

Signed-off-by: Fabian Godehardt <fg@emlix.com>

e2build: fixup collect-project functionality

Signed-off-by: Fabian Godehardt <fg@emlix.com>

e2tool: export e2tool.resultdir(), needed for collect-project

Signed-off-by: Fabian Godehardt <fg@emlix.com>
Conflicts:
local/e2tool.lua

Remove global e2ssh tool

Unused since dinosaurs roamed the earth. There are plenty of other ways
to add arguments to the default ssh tool.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

url: lock url objects against unwanted members

Signed-off-by: Tobias Ulmer <tu@emlix.com>

strict: change API to support fields with nil values

Previously, locked tables could not contain members set to nil,
since Lua is a bit confused about setting something to nil versus it not
existing at all.

Also all members are renamed fields, since "member" is an OO concept,
but the strict module doesn't particularily deal with objects.

The documentation was also slightly improved.

strict.unlock is now implemented, but still untested.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

new-source: remove unhandled --checksum-file opt

While it could be specified, it didn't do anything in particular. While
there, also fix the documentation.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

fix broken error handling in transport.push_file()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

cvs: improve error message and handle scp transports

Signed-off-by: Tobias Ulmer <tu@emlix.com>

transport: improve error message and logging

Signed-off-by: Tobias Ulmer <tu@emlix.com>

improve error messages when creating git repos

Signed-off-by: Tobias Ulmer <tu@emlix.com>

add http/https support to verify_remote_fileid()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

add http/https transport support to the git interface

Signed-off-by: Tobias Ulmer <tu@emlix.com>

use the tools module instead of hardcoding chown

Signed-off-by: Tobias Ulmer <tu@emlix.com>

replace custom mv() with e2lib.mv(), fix error message

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib.mv(): it's safer to pass arguments in a vector

Signed-off-by: Tobias Ulmer <tu@emlix.com>

add bzip2 to the required tools

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove dead code from e2tool

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib: remove unused compute_hash()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2build build_process: remove prio field, unused

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib.directory: readable formatting

Signed-off-by: Tobias Ulmer <tu@emlix.com>

generic/transport.lua: fixup curl support for http/https file transfer

Signed-off-by: Fabian Godehardt <fg@emlix.com>

Remove e2-su and e2-root

e2-su was used up until e2-2.2pre13 (never released to the public). It
was the only user of e2-root.lua.

e2factory until e2factory-2.3.12 will still check for the presence of
e2-su, therefore supply a small shellscript that makes previous versions
happy.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2-root does not need to be executable, trim cleanup files

e2-root is called via e2, does not need to be an executable script. It's
not an entry point into e2factory.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Don't "clean" the internal Lua directory, clean the build results

Signed-off-by: Tobias Ulmer <tu@emlix.com>

rename e2-root.lua.in to e2-root.lua

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove outdated lua.tar.gz documentation part

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Change the way we build Lua

We're now using the internal version of Lua, and set LUA_PATH correctly.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Nothing to replace e2.lua.in anymore, move to its real name

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Do not set package.(c)path, lua does that for us

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Allow adjustment LUA_PATH_DEFAULT and LUA_CPATH_DEFAULT

Signed-off-by: Tobias Ulmer <tu@emlix.com>

vanilla lua-5.1.3.tar.gz

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Lock all modules and plugins with strict.lock()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Use strict module, but allow plugins

Plugins needs permission to create a plugin_descriptor table in the
global environment. Permit this until we have extracted the necessary
information.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Use strict module, but still allow for extending the scm interface

Signed-off-by: Tobias Ulmer <tu@emlix.com>