e2tool: use new sources and results

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Introduce result classes

basic_result class implements all common methods, but can't be used on
its own.

result_class represents the standard result type.

Special results can inherit from one of the two classes, overwriting
methods and such.

Composition is of course also possible, and may even be the better
option for plugins.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

environment: don't format the hash input

Signed-off-by: Tobias Ulmer <tu@emlix.com>

git: use hash_append

Signed-off-by: Tobias Ulmer <tu@emlix.com>

svn: use hash_append

Signed-off-by: Tobias Ulmer <tu@emlix.com>

files: use hash_append

Signed-off-by: Tobias Ulmer <tu@emlix.com>

add ass(e)rt module, provide global assert functions

Assert functions are modeled after luaunit, and share some of its code.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

project: use hash_append

Signed-off-by: Tobias Ulmer <tu@emlix.com>

licence: use hash_append

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib: sort required modules

Signed-off-by: Tobias Ulmer <tu@emlix.com>

chroot: use hash_append

Signed-off-by: Tobias Ulmer <tu@emlix.com>

cvs: use hash_append

Signed-off-by: Tobias Ulmer <tu@emlix.com>

chroot: unbreak module loading loop

Signed-off-by: Tobias Ulmer <tu@emlix.com>

policy: use eio

Signed-off-by: Tobias Ulmer <tu@emlix.com>

err: remove unused getcount() argument

Signed-off-by: Tobias Ulmer <tu@emlix.com>

project: move projid() to sensible location

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Makefiles: stop build process at the error

set -e is no longer necessary since we pass it to SHELL directly.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

err: improve assert error messages

Signed-off-by: Tobias Ulmer <tu@emlix.com>

hash: correct error message

Signed-off-by: Tobias Ulmer <tu@emlix.com>

files: remove unused environment module

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Revert "class: add obj_(un)lock_rw methods for debugging"

This reverts commit 881b2326718b872f02e0bc53ec3676f5e90d20a2.

Improve error handling in hash module

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Improve stringlist insertion and sorting

Signed-off-by: Tobias Ulmer <tu@emlix.com>

class: add obj_(un)lock_rw methods for debugging

Signed-off-by: Tobias Ulmer <tu@emlix.com>

err: add asserts

Signed-off-by: Tobias Ulmer <tu@emlix.com>

remove disabled lock test code

Signed-off-by: Tobias Ulmer <tu@emlix.com>

remove unused stringlist selftest

Signed-off-by: Tobias Ulmer <tu@emlix.com>

remove broken sha1 tests

Signed-off-by: Tobias Ulmer <tu@emlix.com>

environment: remove disabled unit tests

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib.join: fix indentation

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib.join: detect nil components and throw an error.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib.log(): make newline optional

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Handle fetching symlinks correctly, instead of creating 0 size file

This makes symlinks in proj/init work, and should also fix the use of
symlinks in other place. Also, the code should now detect other
non-regular files being fetched and return an error message in this case.

Fixes bz#141

Signed-off-by: Tobias Ulmer <tu@emlix.com>

show per-file licences

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Improve accuracy of fetch-sources manual page

Signed-off-by: Tobias Ulmer <tu@emlix.com>

git source: explicitly fetch tags in addition to objects

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add source module and refactor e2source config handling.

* Introduce a source module with a basic_source class, which all source
  plugins have to implement.
* Move info.sources to source module.
* Turn e2source config tables into defined objects with clear interface.
* Convert all source plugins to class interface, cleaning source
  validation up.
* Improve error checking and detect typos in source configs.
* Add a stringlist module providing a ADT for the common case of dealing
  with arrays of strings.
* Fix files plugin calculation of sourceid when using per-file licences
  entries
* Many small fixes...

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Fix rotating logs when the result name contains a dash

Do not rotate log if not required. General cleanup.

bz#140

e2build: Warn about deploying to a disabled releases server

Signed-off-by: Tobias Ulmer <tu@emlix.com>

cache: add writeback_state()

Make it easy to check whether writeback is on or off for a certain
server.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

transport: add asserts

Signed-off-by: Tobias Ulmer <tu@emlix.com>

cache: Fix comments

Signed-off-by: Tobias Ulmer <tu@emlix.com>

cache: whitespace fixes

Signed-off-by: Tobias Ulmer <tu@emlix.com>

cache: Sprinkle assert()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

assert args

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Don't jump through hoops to get the source name

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Check types of unpack, copy and patch and allow only one per file entry

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Simplify generic_source_default_working()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Doc fix: type of file source is 'files'

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Fix crash on invalid src.licences data type

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove source validation, sources are valid at this point

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Don't crash when "file" in source config is not of the expected type

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Move e2project config handling into project module.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add getter/setter for info table

Doesn't have to be passed as an argument everywhere.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Don't pass main string package into protected environment

The string package can easily be manipulated or variable passed around
in it. Supply each protected environment with its own copy of the
table and only add functions that are considered safe.

Invert resultid/pbuildid ftab error signaling mechanism

Error is now signaled by either false or nil, true to skip and
checksum for everything else. Improve the callback function names for
debug.log and traces. Add documentation all round.

This makes callbacks behave like every other function, instead of a
loaded gun pointing at foot...

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Improve e2tool check_results() doc

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Allow returning error from e2tool.dlist()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Missed return false to error() conversion

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove some locals

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Split chroot config into own module and class

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove unused load functions in load_user_config2()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Initialize the cache early

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove info.chroot.groups and clean up

info.chroot.group_byname contains the same groups. Merge duplicate
documentation, lock most chroot tables, consistently use ipairs().

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Simplify chroot setup by dropping build_config.groups

Use chroot groups of the result instead of going through
build_config.groups. Make sure res.chroot is sorted independent of
proj/chroot.

Previously we did a complicated dance adding all required groups to a
build_config dict and then iterated over the entire chroot table. The
order in which chroot groups were untared did depend on the order of
appearance in proj/chroot.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Change pcall to e2lib.trycall, a wrapper with more debug information

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Whoops, the -f in git checkout was missing

Works so much better now...

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Log all external commands at debug level

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add missed return false on error

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Make dofile2() more strict, improving config file error detection

The capability to disallow global variables and reading undefined
variables in configs existed for a long time but was not enabled for
most files... Implements bz#127

Signed-off-by: Tobias Ulmer <tu@emlix.com>

LicenceID includes the licence name

Makes no sense to hash it twice. Fixes bz#124

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Create licence class and move all licence handling into own module

In addition to all the motions of moving licence out of e2tool, the
following bugs should be fixed in this commit:

svn plugin: Fix bz#123, include LicenceID in SourceID calculation
cvs plugin: Fix bz#126, backtrace when calculating LicenceID

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add or move generic table/attribute verification functions to e2lib

Signed-off-by: Tobias Ulmer <tu@emlix.com>

install class.lua

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add ldoc header for middleclass

Signed-off-by: Tobias Ulmer <tu@emlix.com>

add middleclass

Signed-off-by: Tobias Ulmer <tu@emlix.com>

strict: point error to the stack frame where it occurred

Signed-off-by: Tobias Ulmer <tu@emlix.com>

files: error out if the unpack location doesn't exist after unpacking

A mistake here leads to a confusing error message that is by itself
correct, but hard to understand for the user.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Run e2 tools in protected mode, allowing for use of error()

Convert the top level error handling to error(). Not buying us much as
of now, but it's a start.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Move check_project_info into collect_project_info

The distinction makes little sense now, since collect_project_info also
does a lot of checking.

One less step for local tools required

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove a couple of chroot fields that don't exist any more

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Only 6 X are replaced in by mktemp... functions, shorten

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Document rsync version requirement

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Cleanup collect_project, document, add pbuildid fn...

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2tool: Remove remnants of collect_project

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Move collect_project resultid calculation out of e2tool

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add note about what return values resultid() expects

Signed-off-by: Tobias Ulmer <tu@emlix.com>

There is no r.pseudo_result field anywhere...

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Document e2tool.dsort()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Document e2tool.dlist_recursive() and clarify the code

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Improve documentation, mostly error cases

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove nil in return and error statements

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove some left over error handling

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Don't use stdio to deal with pipes.

Buffering and attempts to loop until a buffer is filled make it
a pain to work with.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

eio: add read, write and close, return file descriptor from pipe()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add read, write, and close wrapers

Stdio only works well with regular files. For pipes, the native syscalls
work much better.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Plug small memory leak in case of poll error

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Reduce and refine tracing a bit

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Fix collect_project, add missing info.cache argument

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Adjust callcmd() to the new poll() interface

Signed-off-by: Tobias Ulmer <tu@emlix.com>