e2tool: sprinkle asserts and fix indentation

Signed-off-by: Tobias Ulmer <tu@emlix.com>

cache: fetch_file() destname and flags are optional now

Signed-off-by: Tobias Ulmer <tu@emlix.com>

strict: add readonly() function

Enforces readonly access on a table. Also errors on accessing nil values

Signed-off-by: Tobias Ulmer <tu@emlix.com>

strict: __index() doesn't take a value

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2tool: error on configured/installed version mismatch

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2tool: remove info argument from umask funcs

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2tool: adjust to build process and build settings

Signed-off-by: Tobias Ulmer <tu@emlix.com>

result: make use of build_process_class

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2build: introduce the build_process class

Every result class has an associated build_process that knows how to
build results of this type.

If a new result class needs to extend the build process, it can inherhit
the class and overwrite methods or insert additional methods registering
them in the constructor.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2build: build_result() never sets return_flags, delete

Can be revived when there's a need

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2build: replace environment_script()

environment.tofile() does the same thing

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2build: don't spam build output into debug.log

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2build: cosmetic cleanup

Signed-off-by: Tobias Ulmer <tu@emlix.com>

inline e2tool.bid_display()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2tool: make set_info() local

Signed-off-by: Tobias Ulmer <tu@emlix.com>

result: use new asserts

Signed-off-by: Tobias Ulmer <tu@emlix.com>

remove package.loaded workaround

Signed-off-by: Tobias Ulmer <tu@emlix.com>

projenv: new module managing project environment

Signed-off-by: Tobias Ulmer <tu@emlix.com>

make.vars: remove unused variables

Signed-off-by: Tobias Ulmer <tu@emlix.com>

environment: add some assertions

Signed-off-by: Tobias Ulmer <tu@emlix.com>

cache: remove tooldebug noise

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib.callcmd(): allow multiple descriptors to use a pipe

Stdout and stderr used to get out of sync due to using a pipe each.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

remove noisy debug output

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib: fix typo in error message

Signed-off-by: Tobias Ulmer <tu@emlix.com>

dlist: use result module, standard naming, drop info

Signed-off-by: Tobias Ulmer <tu@emlix.com>

project: move host system architecture check here

Signed-off-by: Tobias Ulmer <tu@emlix.com>

source: remove sources_sorted table

On closer investigation nothing was using this interface.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

sl: add an unpack() method

Signed-off-by: Tobias Ulmer <tu@emlix.com>

sl: remove methods dealing with insertion order

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2build: switch to result module

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2build: r -> resultname

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2tool.dlist_recursive: rework cyclic error handling

Show only results involved in the cycle. End the cycle with the same
result as it started, making the circular nature more obvious.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2tool: use new sources and results

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Introduce result classes

basic_result class implements all common methods, but can't be used on
its own.

result_class represents the standard result type.

Special results can inherit from one of the two classes, overwriting
methods and such.

Composition is of course also possible, and may even be the better
option for plugins.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

environment: don't format the hash input

Signed-off-by: Tobias Ulmer <tu@emlix.com>

git: use hash_append

Signed-off-by: Tobias Ulmer <tu@emlix.com>

svn: use hash_append

Signed-off-by: Tobias Ulmer <tu@emlix.com>

files: use hash_append

Signed-off-by: Tobias Ulmer <tu@emlix.com>

add ass(e)rt module, provide global assert functions

Assert functions are modeled after luaunit, and share some of its code.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

project: use hash_append

Signed-off-by: Tobias Ulmer <tu@emlix.com>

licence: use hash_append

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib: sort required modules

Signed-off-by: Tobias Ulmer <tu@emlix.com>

chroot: use hash_append

Signed-off-by: Tobias Ulmer <tu@emlix.com>

cvs: use hash_append

Signed-off-by: Tobias Ulmer <tu@emlix.com>

chroot: unbreak module loading loop

Signed-off-by: Tobias Ulmer <tu@emlix.com>

policy: use eio

Signed-off-by: Tobias Ulmer <tu@emlix.com>

err: remove unused getcount() argument

Signed-off-by: Tobias Ulmer <tu@emlix.com>

project: move projid() to sensible location

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Makefiles: stop build process at the error

set -e is no longer necessary since we pass it to SHELL directly.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

err: improve assert error messages

Signed-off-by: Tobias Ulmer <tu@emlix.com>

hash: correct error message

Signed-off-by: Tobias Ulmer <tu@emlix.com>

files: remove unused environment module

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Revert "class: add obj_(un)lock_rw methods for debugging"

This reverts commit 881b2326718b872f02e0bc53ec3676f5e90d20a2.

Improve error handling in hash module

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Improve stringlist insertion and sorting

Signed-off-by: Tobias Ulmer <tu@emlix.com>

class: add obj_(un)lock_rw methods for debugging

Signed-off-by: Tobias Ulmer <tu@emlix.com>

err: add asserts

Signed-off-by: Tobias Ulmer <tu@emlix.com>

remove disabled lock test code

Signed-off-by: Tobias Ulmer <tu@emlix.com>

remove unused stringlist selftest

Signed-off-by: Tobias Ulmer <tu@emlix.com>

remove broken sha1 tests

Signed-off-by: Tobias Ulmer <tu@emlix.com>

environment: remove disabled unit tests

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib.join: fix indentation

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib.join: detect nil components and throw an error.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib.log(): make newline optional

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Handle fetching symlinks correctly, instead of creating 0 size file

This makes symlinks in proj/init work, and should also fix the use of
symlinks in other place. Also, the code should now detect other
non-regular files being fetched and return an error message in this case.

Fixes bz#141

Signed-off-by: Tobias Ulmer <tu@emlix.com>

show per-file licences

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Improve accuracy of fetch-sources manual page

Signed-off-by: Tobias Ulmer <tu@emlix.com>

git source: explicitly fetch tags in addition to objects

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add source module and refactor e2source config handling.

* Introduce a source module with a basic_source class, which all source
  plugins have to implement.
* Move info.sources to source module.
* Turn e2source config tables into defined objects with clear interface.
* Convert all source plugins to class interface, cleaning source
  validation up.
* Improve error checking and detect typos in source configs.
* Add a stringlist module providing a ADT for the common case of dealing
  with arrays of strings.
* Fix files plugin calculation of sourceid when using per-file licences
  entries
* Many small fixes...

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Fix rotating logs when the result name contains a dash

Do not rotate log if not required. General cleanup.

bz#140

e2build: Warn about deploying to a disabled releases server

Signed-off-by: Tobias Ulmer <tu@emlix.com>

cache: add writeback_state()

Make it easy to check whether writeback is on or off for a certain
server.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

transport: add asserts

Signed-off-by: Tobias Ulmer <tu@emlix.com>

cache: Fix comments

Signed-off-by: Tobias Ulmer <tu@emlix.com>

cache: whitespace fixes

Signed-off-by: Tobias Ulmer <tu@emlix.com>

cache: Sprinkle assert()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

assert args

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Don't jump through hoops to get the source name

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Check types of unpack, copy and patch and allow only one per file entry

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Simplify generic_source_default_working()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Doc fix: type of file source is 'files'

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Fix crash on invalid src.licences data type

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove source validation, sources are valid at this point

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Don't crash when "file" in source config is not of the expected type

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Move e2project config handling into project module.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add getter/setter for info table

Doesn't have to be passed as an argument everywhere.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Don't pass main string package into protected environment

The string package can easily be manipulated or variable passed around
in it. Supply each protected environment with its own copy of the
table and only add functions that are considered safe.

Invert resultid/pbuildid ftab error signaling mechanism

Error is now signaled by either false or nil, true to skip and
checksum for everything else. Improve the callback function names for
debug.log and traces. Add documentation all round.

This makes callbacks behave like every other function, instead of a
loaded gun pointing at foot...

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Improve e2tool check_results() doc

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Allow returning error from e2tool.dlist()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Missed return false to error() conversion

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove some locals

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Split chroot config into own module and class

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove unused load functions in load_user_config2()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Initialize the cache early

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove info.chroot.groups and clean up

info.chroot.group_byname contains the same groups. Merge duplicate
documentation, lock most chroot tables, consistently use ipairs().

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Simplify chroot setup by dropping build_config.groups

Use chroot groups of the result instead of going through
build_config.groups. Make sure res.chroot is sorted independent of
proj/chroot.

Previously we did a complicated dance adding all required groups to a
build_config dict and then iterated over the entire chroot table. The
order in which chroot groups were untared did depend on the order of
appearance in proj/chroot.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Change pcall to e2lib.trycall, a wrapper with more debug information

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Whoops, the -f in git checkout was missing

Works so much better now...

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Log all external commands at debug level

Signed-off-by: Tobias Ulmer <tu@emlix.com>