e2build: for interactive playground use, setup standard file descriptors

Because we request a pty for signaling purposes, interactive use of the
shell isn't possible. To enable interactive use, duplicate the standard
descriptors of the parent and set them up in the child which will end
up being bash.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2build: use e2lib.get_tool_flags_argv_e2_su_2_2

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib: e2_su_2_2 factor out tool command construction

e2lib.get_tool_flags_argv_e2_su_2_2 is now used to return the various
possible combinations of e2-su-2.2 calls, ready for arguments to be
inserted.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib: extend call_tool_argv to return exit code of tool

Signed-off-by: Tobias Ulmer <tu@emlix.com>

eio: implement dup()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

git: use appropriate wait wrapper

Signed-off-by: Tobias Ulmer <tu@emlix.com>

call e2-su-2.2 and sudo with pty=true

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2tool: disable write buffering for debug.log

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2: install signal handler and dispose our subprocess

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib: callcmd: add argument to run command under a pseudo tty

Running under a pseudo tty allows using the TIOCSIG ioctl to terminate
non-user owned processes, in particular setuid programs like e2-su or
sudo.

Various improvements around signal handling during forking, with better
error handling and reporting.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib: finish: if we received a signal, exit with the signal code

Receiving a signal causes subsequent errors which hide the true cause
for termination. Make sure we always exit with 128 + signalno and let
the user know that above errors were caused by a signal.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib: interrupt_hook: send interrupt to children

note interrupt_hook() no longer terminates e2factory

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib: add children_.. functions to track and terminate sub processes

If a child process has an associated pseudo terminal, it's terminated
via TIOCSIG ioctl, otherwise the standard kill() function is used.

Allows us to interrupt root-owned children (eg e2-su, sudo, ...)

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib: support waitpid WNOHANG with wait(pid, true)

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Makefile: link against libutil, required by forkpty()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

assrt: pass optional message to assert()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib: close unused sync pipe ends before reading from child

Otherwise we could end up in a situation where we wait for a faulty
child, but hang reading our own pipe.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib: handle read EINTR in poll loop

Maybe eio.read() should generally loop on EINTR?

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib: rename: don't shadow the errno module

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib: wait: format log message

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib: handle EINTR in poll() and wait()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

transport: rename file instead of calling mv

Signed-off-by: Tobias Ulmer <tu@emlix.com>

le2lib: block other signals during signal handler execution

Signed-off-by: Tobias Ulmer <tu@emlix.com>

le2lib: add a ioctl(TIOCSIG) wrapper function

Signed-off-by: Tobias Ulmer <tu@emlix.com>

le2lib: add functions to block and unblock signals

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib: implement forkpty

Signed-off-by: Tobias Ulmer <tu@emlix.com>

eio: log pipe file descriptors

Signed-off-by: Tobias Ulmer <tu@emlix.com>

le2lib: poll: provide information about POLLERR/POLLHUP/POLLNVAL

Signed-off-by: Tobias Ulmer <tu@emlix.com>

le2lib: return errno value from poll

Signed-off-by: Tobias Ulmer <tu@emlix.com>

le2lib: return errno value from waitpid

Signed-off-by: Tobias Ulmer <tu@emlix.com>

le2lib: stop calling fflush in the fork wrapper

Signed-off-by: Tobias Ulmer <tu@emlix.com>

eio: use luaL_error

Signed-off-by: Tobias Ulmer <tu@emlix.com>

eio: add fflush()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib: if logf() format fails, abort with helpful message

Signed-off-by: Tobias Ulmer <tu@emlix.com>

tools: fix undeclared variable in error message

Signed-off-by: Tobias Ulmer <tu@emlix.com>

files: fix collect project whitespace handling in file names

This closes bz#239.

Also fixes a rare issue with the copying of files into an existing
directory.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2tool: open debug.log after loading e2.conf

Makes debug.log respect config.log.logrotate.
Closes bz#236.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

lock: provide instructions to fix a locked chroot

Signed-off-by: Tobias Ulmer <tu@emlix.com>

generic_git: document git_remote_add() and improve remote handling

Signed-off-by: Tobias Ulmer <tu@emlix.com>

generic_git: add a few helpers for formatting refs

Signed-off-by: Tobias Ulmer <tu@emlix.com>

files: add support for .tbz2 archives

Signed-off-by: Tobias Ulmer <tu@emlix.com>

fetch-project: enforce mutual exclusivness of --tag and --branch

Signed-off-by: Tobias Ulmer <tu@emlix.com>

fetch-project: fix detached HEAD status when using --branch

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2-new-source: load project after option handling

generic_git: documentation

e2build: display longer more of the scratch buildid

collect_project: in wc-mode, return a scratch buildid

Due to hashing the dependant results of a cp result, the scratch buildid
status was dropped from the buildid. Aside from an unlikely hash collision,
this does not affect other build modes, but is of course not correct.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

policy: document handle_commandline_options

Unify git refs formatting

Signed-off-by: Tobias Ulmer <tu@emlix.com>

generic_git: turn errors into assertion

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib: fix locate_project_root

Signed-off-by: Tobias Ulmer <tu@emlix.com>

lock: log errors on cleanup, improve

Signed-off-by: Tobias Ulmer <tu@emlix.com>

err: add tostring() method

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib: don't close debuglogfile early, improve performance

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2build: check for chroot removal, add error message for common issue

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2build: clarify creation of directories

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2build: ouch, repair error handling in helper_chroot_remove()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Improve robustness of signal handling

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib: don't call chdir in rmtempdirs

Signed-off-by: Tobias Ulmer <tu@emlix.com>

eio: luaL_argerror never returns, but it helps gcc warnings

Signed-off-by: Tobias Ulmer <tu@emlix.com>

console: set stderr to unbuffered

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2build: use result_build_set to skip build steps

Remove return_flags.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Introduce build_set and result_build_set.

A build set contains a result build sets for each result we want to
build. The result build set contains all configurable settings, modes,
etc. on a per result basis.
This change disentangles all build specific parameters from the static
project configuration.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

result: split build_config() into builtin_env()

Builtin env requires a BuildID, which in turn requires a fully set up
result with build modes etc. just to figure out the temporary directory.

Thus it makes sense to split build_config() into two methods operations,
with only builtin_env() requiring full setup work.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2build: fix ldoc tag

Signed-off-by: Tobias Ulmer <tu@emlix.com>

err: fix ldoc tags

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2tool: remove unused print_selection and selected marker

Signed-off-by: Tobias Ulmer <tu@emlix.com>

move build mode and settings into the build process

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2tool: false is a valid value in settings

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2tool: remove select_results()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2build: clear up confusion between build mode and process mode

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib: make use of errcode in mkdir()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib: in mkdir() use same parse_mode argument

Signed-off-by: Tobias Ulmer <tu@emlix.com>

errno: register errno constants as errcodes

Signed-off-by: Tobias Ulmer <tu@emlix.com>

err: attach meaningful codes to error objects

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2project: introduce a class for the local project

Signed-off-by: Tobias Ulmer <tu@emlix.com>

err: improve documentation

Signed-off-by: Tobias Ulmer <tu@emlix.com>

le2lib: return error if fflush before fork fails

Signed-off-by: Tobias Ulmer <tu@emlix.com>

cache: export file_in_cache()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

generic_git: allow passing workdir to git()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add optional sudo support to e2factory

Once sudo is enable, e2-su-2.2 suid permissions can be removed and set
to 755.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

create next changelog entry

Signed-off-by: Tobias Ulmer <tu@emlix.com>

release e2factory-2.3.17p0

Signed-off-by: Tobias Ulmer <tu@emlix.com>

update changelog

Signed-off-by: Tobias Ulmer <tu@emlix.com>

git: wait for pipe children in any order

Signed-off-by: Tobias Ulmer <tu@emlix.com>

tools: extend for enable

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2-build: allow --wc-mode foo,bar and add warning

When specifying multiple build modes, warn if there is a default
selected result. It may or may not be what you want.

Add field splitting to build-mode options, currently , and whitespace
are supported.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

generic_git: fix error handling

found by Anton Hillebrand <ahille@emlix.com>

Signed-off-by: Tobias Ulmer <tu@emlix.com>

err: stop evaluation of debug.traceback() every time

Signed-off-by: Tobias Ulmer <tu@emlix.com>

le2lib: remove do_parse_mode()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Moved parse_mode code from c to lua.

Signed-off-by: Anton Hillebrand <ahille@emlix.com>

transport: remove duplicate comment and rmtempfile call

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib: implement rename(), use in rotate_log()

This makes it independent of the "mv" command, allowing to open and
rotate the log file before the tools module is initialized.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

le2lib: add implementation of rename(2)

Signed-off-by: Tobias Ulmer <tu@emlix.com>

digest: allow writing SHA256 digests

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2-build: check for duplicate results in build mode arguments

Signed-off-by: Tobias Ulmer <tu@emlix.com>

add buildid logging to help with debugging

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib: fix e2lib.wait() for signaled process

wait() returned 0 for a signaled process, expecting the caller to
check the third argument for a signal code.

Most call sites do not observe the signal argument, leading to
"successful" execution of a crashing process.

wait() will now return the exit code or signal + 128 in the first
argument. This is in line with various shells.

Also improve debug logging around wait() and callcmd().

Signed-off-by: Tobias Ulmer <tu@emlix.com>

create next changelog entry

Signed-off-by: Tobias Ulmer <tu@emlix.com>

release e2factory-2.3.17

Signed-off-by: Tobias Ulmer <tu@emlix.com>