Introduce elib.callcmd() with more flexibility

Commands can now be passed as argument vectors straight into execvp().
This removes all shell quoting headaches when going through this
interface.
File descriptors can be set up in a table-driven way as necessary.
A workdir for the child can be set. Environment variables can be
supplied now.

All callcmd friends are either removed or converted to this interface
with the exception of callcmd_pipe().

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove shell command constructs from git.toresult()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Improve error reporting in e2lib.setenv()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Implement e2lib.execvp()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Move patch() into files plugin and convert to argv

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib.cp: change flags to recursive and use an argv

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Initialize shift, gcc complains because the conditions are a little twisted

Disable do_unsetenv() for now, silences gcc complaints

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Inline callcmd() in callcmd_pipe() in order to remove later

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Correct e2lib.poll() documentation

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Repair error reporting in e2lib.wait()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Improve eio error messages, keep the file name/fd around

Signed-off-by: Tobias Ulmer <tu@emlix.com>

eio.fread() now requires a size

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Use eio in hash_file()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add "size" argument to eio.fread()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Replace shell command mktemp with a mkstemp() call.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Provide mkstemp() wrapper

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Replace shell command mktemp -d with a mkdtemp() call.

One more io.popen() is gone.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add mkdtemp() wrapper.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

lib is an array, dereferencing it for a pointer is wrong.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

isdigit() is declared in ctype.h, include it

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Replace popen() with callcmd_capture() and require missing err module.

Due to pure luck, nobody ran into a code path using err yet...

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Stop accessing private hash context fields, call hash functions via module

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Mark the hash context fields private, force calls to go through module

Make it possible to grep for calls and change the implementation.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Fix crash on MD5 checksum entry

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Convert digest.parse() to eio

Use digest functions to construct digest table and entries.
Fix a file descriptor leak.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove unused global env table

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove global interactive flag

Was probably once used to enter a debug mode. Since that's no more,
axe the variable.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

We don't use hostname for anything, remove the code

Another io.popen call bites the dust.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Could not find out what use the "mmm" sourceset is, remove it

Introduced in 53183d030127937d41a5bf211b22255cd4991eec, without a single
reference anywhere, nor explanation why sourceset would be "mmm"...

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Include PID in trace logging

Surprisingly no measurable increase in run time

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Extend trace module to allow for filtering

Attempt to reduce the debug.log noise by filtering the err module
warnf/logf calls and others.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Move e2lib.svn() into the SVN plugin

Signed-off-by: Tobias Ulmer <tu@emlix.com>

git_init_db1(): remove default behaviour, require a choice

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove e2lib.git comment

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Merge git_new_argv2() into generic_git.git_new_argv()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove e2lib.git() for good

Signed-off-by: Tobias Ulmer <tu@emlix.com>

All generic_git.git_rev_list1() users are gone, delete it

Signed-off-by: Tobias Ulmer <tu@emlix.com>

In git.check_workingcopy(), use lookup_id to find the branch

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Sync fetch_source with fetch-project, use lookup_id and clean up

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Overhaul git.update() making use of the work in generic_git

Update does not create merge commits any more. This change requires a
git version supporting git merge --ff-only. Tested with version 1.6.6.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

git.git_commit_id(): use lookup_id() function

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Use absolute GIT_DIR path, decouple errors from dirty/mismatch flag

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Simplify generic_git.verify_remote_tag() using new lookup functions

Gets rid of the temporary remote tag that could potentially destroy a
valid tag if there was a name collision.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Replace e2lib.git() with generic_git functions.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add generic_git.lookup_id() and lookup_ref()

Interface to provide translation between a git reference and git
commit ID.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Fix git name and note the oldest supported git version.

Older versions should still work, but fetch-sources --update uses
--ff-only which does not exist in earlier versions.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Use git_checkout() instead of hand-rolled solution

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2-install-e2: make destdir an absolute path

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2-fetch-project: make p.destdir an absolute path

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Wean e2-create-project off of e2lib.git and use generic_git

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add git_commit_id() function to git SCM plugin and clean up

This function may come handy in other plugins. Makes use of the
fixed generic_git.git_rev_list1() function.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Complete overhaul of generic_git module

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add url.to_file_path()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove now unused e2lib.ssh(), improve ssh_remote_cmd()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Use ssh_remote_cmd() to create directory

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add ssh_remote_cmd(), a wrapper for executing commands remotely

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Document url object fields some more

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Allow SCM modules to register interfaces not common to all modules

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Extend documentation of e2lib.callcmd_capture()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Generate documentation for plugins again.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Do not mangle module name with an underscore in debug log

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Replace write_file with eio.file_write()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Convert write_extension_config() to eio and move into e2-create-project

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Merge read_file() and read_template() into a local function

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Replace read_line with eio.file_read_line()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Disable tracing in parts of hash and eio module

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add trace module, used for logging all function calls

Remove previous implementation from e2lib and move it into a
free-standing module. Extend so it can be disabled and enabled when
convenient.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Rename luafile to EIO (Extended IO) remove confusing module/argument naming

No functional change

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Use new luafile API and check for errors in more places

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Rewrite luafile

Turn into a "modern" module like the rest, document, add error
handling and remove all methods not in use by current code.
Remove object-style access like f:close() to increase grepability
of the code. Rename methods to their C equivalents.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove all of e2lib.touch() and friends

Replace one usage with basic open()/close() to create the chroot marker

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Improve luafile documentation

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove chmod the tool.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Fixup e2lib.chmod() callers

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Replace chmod tool by function call and document it

Swap arguments to be the same as chmod(2)

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Update e2lib.parse_mode() doc

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add chmod function

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add octal number parsing to parse_mode, sprinkle some comments

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove E2_LOCAL_TAG and E2_LOCAL_BRANCH environment variables

Looks like these were initially used for automated tests.  The same
settings can now be made in e2.conf.

Nothing that I know of has known or used these environment variables, so
I consider it OK to "break" backwards compat.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove more obsolete tools

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Document 3rd party sources for completeness

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove unused mkdir tool entry

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add new mkdir(), mkdir_recursive and parse_mode() functions

Replace all calls to the external mkdir tool with our own mkdir
code.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add errno module

Translates magic errno numbers into sensible strings and back.

Will be used by some C interface functions whose error codes we
have to treat in other ways than just signaling a fatal error.

Add authors of e2factory

Extracted from git log of the free software version as well as the
previous internal project.

Sorted by last year of contribution and primary contact/volume.
Active developers have an email address.

Sorry to all I forgot, please feel free to contact me to get added.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add basic luafile documentation

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Replace e2lib.get_sys_arch() with uname_machine()

No more parsing of uname output...

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Consolidate e2util into e2lib, add error reporting and new functions

Remove duplicate and unused functions. Add and verify error handling
on all call-sites of the new or renamed functions.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove all traces of e2lib.bomb

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove call to e2lib.bomb()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove call to e2lib.bomb()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove calls to e2lib.bomb()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Update e2lib.get_sys_arch() doc

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove unused globals.terminal variable

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Update e2lib.sha1sum documentation

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Update documentation of e2lib.call_tool

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add error handling to tools module and all call sites

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Replace callcmd_capture with callcmd_log

Cleanup and clarify error handling

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Modify callcmd_log() to return an error object

Signed-off-by: Tobias Ulmer <tu@emlix.com>