Remove unused global variable 'termwidth'

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove unused global variable 'last_output'

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove e2lib.callcmd_redirect(), unused

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Move e2-su-2.2.c in the ldoc config

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Replace string.format with e2lib.join() for paths

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Convert buildconfig into a new-style module

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib.callcmd() is for internal use only, mark local

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Cleanup Makefiles, move files in the right place, stop abusing VPATH

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Lock build_mode table, cleanup and document

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Update result documentation

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Handle mkdir() errors in collect_project()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Generate Makefile with upper-case initial

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Use e2lib.join() instead of string.format() to construct paths

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove outdated phash/bhash documentation

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove build_config.env, duplicate data

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Build results without unused indirection via function table

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Move reading chroot config into function, cleanup duplicates

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Document build_process table

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Fix indentation

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Cleanup build_config() and update documentation

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Use info.project instead

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Document and cleanup load_user_config()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Repair, document and simplify gather_{source,result}_paths() functions

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove remnants of build-numbers support

This also removes the E2_BUILD_NUMBER variable

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Fix indentation

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add error checking to directory() loops

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Rework directory() iterator to not use abort()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove comments about abort

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Adjust callers of e2lib.callcmd_pipe()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Rework callcmd_pipe() to not use abort()

Rename and restructure it a bit to make it more understandable

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Replace abort() in guards of dofile2() with error()

Here error() is called in a protected environment. We get an error
message back instead of instantly terminating the program.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Correct buildid() documentation

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove unused function check_workingcopies()

Reported by Thomas Brinker

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove unused parameters from e2tool.check_project_info()

Reported by Thomas Brinker

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove redundant p.server assignment

Reported by Thomas Brinker

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Merge dofile_protected() into dofile2()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

remove unused e2lib.parse_versionfile()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add error handling to e2lib.mktempfile()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add error handling to e2lib.mktempdir()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Rework error handling in parse_e2versionfile()

Remove e2_has_fixed_tag() its return values conflict with error
reporting and we can just inline the single use (minus the messages)

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add error handling to e2lib.get_global_config()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add error handling to e2lib.init2()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Make use_global_config() local and remove calls to abort()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2lib.init() can now return errors

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Handle errors from e2option.parse()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2option: remove abort() wherever possible

Remaining calls to finish() and abort() should only affect command
arguments that are expected to exit the process immediately.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

generic_git: remove all calls to abort()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

plugin: remove call to abort()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2tool: select_result() now returns error instead of calling abort()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2tool: buildid() now returns error instead of calling abort()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2tool: remove abort() from projid() and pbuildid()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2tool: remove abort() from collect_project_info()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

cvs: remove e2lib.abort()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

files: remove elib.abort()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

policy: remove e2lib.abort()

handle_commandline_options() now return an err object

Signed-off-by: Tobias Ulmer <tu@emlix.com>

git: remove e2lib.abort()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

svn: remove e2lib.abort()

Remove calls to e2lib.abort() in global tools

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Remove calls to e2lib.abort() in local tools

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Put local tools code into functions

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Put global tool code into functions

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Fix dsort module name

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Format and remove log messages

Signed-off-by: Tobias Ulmer <tu@emlix.com>

git: fetch tags and pull ff-only

Signed-off-by: Tobias Ulmer <tu@emlix.com>

create next changelog entry

Signed-off-by: Tobias Ulmer <tu@emlix.com>

release e2factory-2.3.14p1

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Document .e2/e2config

Signed-off-by: Tobias Ulmer <tu@emlix.com>

add unoffical E2_TRACE env var, for debugging only

Not documented, may go away or change without notice

Signed-off-by: Tobias Ulmer <tu@emlix.com>

chroot template: don't point to internal resources

Signed-off-by: Tobias Ulmer <tu@emlix.com>

init: wrap io.open/popen with variants setting FD_CLOEXEC

Signed-off-by: Tobias Ulmer <tu@emlix.com>

init: close everything but stdin, stdout and stderr

Signed-off-by: Tobias Ulmer <tu@emlix.com>

check whether open(/dev/null) succeeded

Signed-off-by: Tobias Ulmer <tu@emlix.com>

plug a number of file descriptor leaks

Signed-off-by: Tobias Ulmer <tu@emlix.com>

set FD_CLOEXEC on dup'ed file descriptors in child

Be careful not to close the descriptor we want to pass on (0, 1, 2)

Signed-off-by: Tobias Ulmer <tu@emlix.com>

luafile: new function cloexec() to set FD_CLOEXEC on file

Signed-off-by: Tobias Ulmer <tu@emlix.com>

luafile: open now sets FD_CLOEXEC by default

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2util: implement closefrom()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2build: fix wrong use of shquote(), makes x86_64 chroot work

Signed-off-by: Tobias Ulmer <tu@emlix.com>

chroot arch: fix regression, make x86_64 work again

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Makefile: stop exporting so many environment variables

This export business is annoying while testing e2factory during
development . It's also difficult to reason about the origin of a
variable value, since they show up by including make.vars as well as
being inherited through the environment. The only obvious user has been
converted (GENSCRIPT)

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Makefile: explicitly pass build variables to genscript.sh

Use $(GENSCRIPT) to call the script from any Makefile

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Makefile: remove 'tags' target

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Makefile: remove unused 'check' target

Signed-off-by: Tobias Ulmer <tu@emlix.com>

hashcache: prevent erroneous same-second cache hits

One second resolution is clearly not enough. Compare nanosecond mtime
and ctime as well as size to prevent accidental cache hits.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

e2util.stat(): provide nanosecond precision

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Reset all signal handlers to their defaults

bz#147

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Fix rotating logs when the result name contains a dash

Do not rotate log if not required. General cleanup.

bz#140

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Handle fetching/pushing symlinks instead of creating empty files

This makes symlinks in proj/init work, and should also fix the use of
symlinks in other place. Also, the code should now detect other
non-regular files being fetched and return an error message in this case.

Fixes bz#141

Signed-off-by: Tobias Ulmer <tu@emlix.com>

mention curl as requirement

create next changelog entry

Signed-off-by: Tobias Ulmer <tu@emlix.com>

release e2factory-2.3.14p0

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Unbreak --wc-mode and make it work with intermediary deps

Adds a partially random buildid to scratch results, triggering a rebuild
of any result that has a scratch result in its dependency chain.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Forbid --all with results and --wc-mode without results

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Fix svn.sourceid(), include SVN revision in sourceid

Previously the svn plugin would not notice moving tags and branch mode
was broken. Also fixes licenseid calculation for svn sources.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Add e2lib.call_tool_argv_capture()

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Fix operator precedence in licence validation

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Fix operator precedence in cvs and svn source validation

"not" binds higher, turning these expressions into false == "string" on
errors.

src.tag not being set causes a stack trace later on.

A regression test has been added.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Fix error in tartype_by_suffix()

Found by Wolfgang Gehrhardt

Signed-off-by: Tobias Ulmer <tu@emlix.com>

Fix collect_project regression

Make collect_project work with init files again. A regression test
has been added.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

create next changelog entry

Signed-off-by: Tobias Ulmer <tu@emlix.com>