From: Gordon Hecker <gh@emlix.com>
Date: Fri, 2 Oct 2009 13:03:11 +0000 (+0200)
Subject: fix configuration validation for files sources
X-Git-Tag: e2factory-2.3.2rc1~46
X-Git-Url: https://git.e2factory.org/?a=commitdiff_plain;h=d54a4af11b8dc7340ce443ef5b150dd7ab5a2c71;p=e2factory.git

fix configuration validation for files sources

Signed-off-by: Gordon Hecker <gh@emlix.com>
---

diff --git a/Changelog b/Changelog
index e6459fd..21644f2 100644
--- a/Changelog
+++ b/Changelog
@@ -7,6 +7,7 @@ NEXT:
  * hardlinks are used when preparing the result tarball, if possible, to
    improve performance
  * logfiles are rotated instead of deleting them
+ * a bug in configuration validation for files sources was fixed
  * unused code was removed
  * the faq section in the documentation was extended
  * outdated documentation was removed
diff --git a/local/files.lua b/local/files.lua
index 0b825a8..bd7b7ea 100644
--- a/local/files.lua
+++ b/local/files.lua
@@ -50,6 +50,11 @@ function files.validate_source(info, sourcename)
   end
   if src.file then
     for _,f in pairs(src.file) do
+      if type(f) ~= "table" then
+	e:append("%s: source has invalid file entry in `file' attribute",
+								sourcename)
+	break
+      end
       -- catch deprecated configuration
       if f.name then
 	e:append("source has file entry with `name' attribute")