From: Tobias Ulmer <tu@emlix.com>
Date: Thu, 3 Nov 2016 17:06:16 +0000 (+0100)
Subject: cache: warn about missing push_permissions
X-Git-Tag: e2factory-2.3.15rc1~20
X-Git-Url: https://git.e2factory.org/?a=commitdiff_plain;h=5f8ebb412b80ee851a72c9f1228a6b92fabb2d96;p=e2factory.git

cache: warn about missing push_permissions

Signed-off-by: Tobias Ulmer <tu@emlix.com>
---

diff --git a/generic/cache.lua b/generic/cache.lua
index edbff6b..fe3b7a0 100644
--- a/generic/cache.lua
+++ b/generic/cache.lua
@@ -739,6 +739,8 @@ local function cache_writeback(c, server, location, flags)
     return true
 end
 
+local _pp_warn = true
+
 --- push a file to a server: cache and writeback
 -- @param c a cache table
 -- @param sourcefile where to store the file locally
@@ -758,6 +760,12 @@ function cache.push_file(c, sourcefile, server, location, flags)
         return false, e:cat(re)
     end
 
+    if _pp_warn and not ce.flags.push_permissions then
+        e2lib.warnf("WOTHER", "push_permissions for server %s not set, "..
+            "file permissions may be wrong", server)
+        _pp_warn = false
+    end
+
     if cache.cache_enabled(c, server, flags) then
         -- cache is enabled:
         -- push the file from source to cache and from cache to