From: Tobias Ulmer <tu@emlix.com>
Date: Tue, 10 Jul 2012 13:05:44 +0000 (+0200)
Subject: Quote most e2lib.git() parameters
X-Git-Tag: e2factory-2.3.12rc1~23
X-Git-Url: https://git.e2factory.org/?a=commitdiff_plain;h=23229d75bf2e89709b91958fddf1c4e12d209625;p=e2factory.git

Quote most e2lib.git() parameters

Signed-off-by: Tobias Ulmer <tu@emlix.com>
---

diff --git a/generic/e2lib.lua b/generic/e2lib.lua
index 7d65d79..718bbf3 100644
--- a/generic/e2lib.lua
+++ b/generic/e2lib.lua
@@ -1580,8 +1580,9 @@ function git(gitdir, subtool, args)
 	if not git then
 		return false, e:cat(re)
 	end
-	local call = string.format("GIT_DIR='%s' %s %s %s", gitdir, git,
-								subtool, args)
+	-- TODO: args should be quoted as well
+	local call = string.format("GIT_DIR=%s %s %s %s",
+	    shquote(gitdir), shquote(git), shquote(subtool), args)
 	rc, re = callcmd_log(call)
 	if rc ~= 0 then
 		e:append(call)