From: Tobias Ulmer <tu@emlix.com>
Date: Thu, 12 Jul 2012 14:24:08 +0000 (+0200)
Subject: Instead of crashing, error out when no build number server is configured
X-Git-Tag: e2factory-2.3.12rc1~7
X-Git-Url: https://git.e2factory.org/?a=commitdiff_plain;h=22b46fdc03b74a240620b1c4684c82d777e5bd34;p=e2factory.git

Instead of crashing, error out when no build number server is configured

Signed-off-by: Tobias Ulmer <tu@emlix.com>
---

diff --git a/local/e2tool.lua b/local/e2tool.lua
index e33c95f..63cef27 100644
--- a/local/e2tool.lua
+++ b/local/e2tool.lua
@@ -2257,6 +2257,11 @@ end
 -- @return an error object on failure
 function buildnumber_request(info)
 	e2lib.log(3, "requesting build numbers from server")
+
+        if e2lib.globals.buildnumber_server_url == nil then
+          return false, new_error("no build number server configured")
+        end
+
 	local rc, re
 	local e = new_error("error requesting build numbers")
 	local tmpdir = e2lib.mktempdir()
@@ -2265,8 +2270,8 @@ function buildnumber_request(info)
 	local curlflags = "--create-dirs --silent --show-error --fail"
 	local url = string.format(
 		"'%s?project=%s&user=%s&host=%s'",
-		e2lib.buildnumber_server_url, info.name,
-		e2lib.globals.osenv["USER"], e2lib.hostname)
+		e2lib.globals.buildnumber_server_url, info.name,
+		e2lib.globals.osenv["USER"], e2lib.globals.hostname)
 	local args = string.format(
 			"%s " ..
 			"--header 'Content-type: text/plain' " ..