From: Tobias Ulmer Date: Wed, 3 May 2017 17:01:45 +0000 (+0200) Subject: transport: remove duplicate comment and rmtempfile call X-Git-Tag: e2factory-2.3.17p0~9 X-Git-Url: https://git.e2factory.org/?a=commitdiff_plain;h=1d69c138685e79c18e1052bbc013eab91649d37d;p=e2factory.git transport: remove duplicate comment and rmtempfile call Signed-off-by: Tobias Ulmer --- diff --git a/generic/transport.lua b/generic/transport.lua index d76926f..2272e63 100644 --- a/generic/transport.lua +++ b/generic/transport.lua @@ -189,13 +189,6 @@ function transport.fetch_file(surl, location, destdir, destname) -- missing error detection. e2lib.rmtempfile(tmpfile_path) - -- Some tools (rsync) do not return an error code when skipping symlinks, - -- device files, etc. Thus we delete the tmp file here, let rsync do its - -- job, and detect the silent error condition when moving the file to its - -- final destination. Yes there is a race, but we take that chance over - -- missing error detection. - e2lib.rmtempfile(tmpfile_path) - -- fetch the file to the temporary directory if u.transport == "http" or u.transport == "https" then