From: Tobias Ulmer <tu@emlix.com>
Date: Wed, 6 Nov 2013 14:08:47 +0000 (+0100)
Subject: git_init_db1(): remove default behaviour, require a choice
X-Git-Tag: e2factory-2.3.15rc1~407
X-Git-Url: https://git.e2factory.org/?a=commitdiff_plain;h=19106376d741e466e2ad1d778d62f1a76a8e0a6a;p=e2factory.git

git_init_db1(): remove default behaviour, require a choice

Signed-off-by: Tobias Ulmer <tu@emlix.com>
---

diff --git a/generic/generic_git.lua b/generic/generic_git.lua
index 28a0ebd..2ecc2b6 100644
--- a/generic/generic_git.lua
+++ b/generic/generic_git.lua
@@ -344,18 +344,12 @@ end
 --- Initialize a git repository.
 -- @param rurl URL string where the repository should be created.
 -- @param shared Should the repository be shared with other users or not.
---               Defaults to true.
 -- @return True on success, false on error.
 -- @return Error object on failure.
 function generic_git.git_init_db1(rurl, shared)
     local rc, re, e, u, gitdir, gitargv, argv
 
-    -- XXX: Remove the default behaviour and require a choice
-    if shared == nil then
-        shared = true
-    end
-
-    if not rurl then
+    if not rurl or type(shared) ~= "boolean" then
         return false, err.new("git_init_db1(): missing parameter")
     end
 
@@ -560,7 +554,7 @@ function generic_git.git_init_db(c, server, location)
     if not rurl then
         return false, e:cat(re)
     end
-    local rc, re = generic_git.git_init_db1(rurl)
+    local rc, re = generic_git.git_init_db1(rurl, true)
     if not rc then
         return false, re
     end