From: Tobias Ulmer <tu@emlix.com>
Date: Fri, 1 Mar 2019 16:24:00 +0000 (+0100)
Subject: generic_git: use arg instead of reinventing the wheel
X-Git-Tag: e2factory-2.3.18rc1~25
X-Git-Url: https://git.e2factory.org/?a=commitdiff_plain;h=096f17cf1bcf46529144229f70c9f88ed264a798;p=e2factory.git

generic_git: use arg instead of reinventing the wheel

Signed-off-by: Tobias Ulmer <tu@emlix.com>
---

diff --git a/generic/generic_git.lua b/generic/generic_git.lua
index 8f23ca5..a777823 100644
--- a/generic/generic_git.lua
+++ b/generic/generic_git.lua
@@ -140,8 +140,6 @@ end
 -- @param ... Further arguments are added to the end of the argument vector.
 -- @return Argument vector table.
 function generic_git.git_new_argv(git_dir, work_tree, ...)
-    local argv = {...}
-
     if git_dir == nil and work_tree then
         git_dir = e2lib.join(work_tree, ".git")
     end
@@ -150,13 +148,13 @@ function generic_git.git_new_argv(git_dir, work_tree, ...)
     end
 
     if work_tree then
-        table.insert(argv, 1, "--work-tree="..work_tree)
+        table.insert(arg, 1, "--work-tree="..work_tree)
     end
     if git_dir then
-        table.insert(argv, 1, "--git-dir="..git_dir)
+        table.insert(arg, 1, "--git-dir="..git_dir)
     end
 
-    return argv
+    return arg
 end
 
 --- Call out to git.