Fix operator precedence in cvs and svn source validation

"not" binds higher, turning these expressions into false == "string" on
errors.

src.tag not being set causes a stack trace later on.

A regression test has been added.

Signed-off-by: Tobias Ulmer <tu@emlix.com>

diff --git a/local/cvs.lua b/local/cvs.lua
index c627656e97dc110743f9efea885255c69cef1f96..7b2599ce8c17cd61c51e31bc5bdcba3fab50594c 100644 (file)
--- a/local/cvs.lua
+++ b/local/cvs.lua
@@ -85,7 +85,7 @@ function cvs.validate_source(info, sourcename)
     if not src.branch then
         e:append("source has no `branch' attribute")
     end
-    if not type(src.tag) == "string" then
+    if type(src.tag) ~= "string" then
         e:append("source has no `tag' attribute or tag attribute has wrong type")
     end
     if not src.module then

diff --git a/local/svn.lua b/local/svn.lua
index 185c7cbbc310cd9136cd8a8ff297539ccf216071..d78ac23aa272d2e90af138f62c711549d8d7be9c 100644 (file)
--- a/local/svn.lua
+++ b/local/svn.lua
@@ -365,10 +365,10 @@ function svn.validate_source(info, sourcename)
     if not src.branch then
         e:append("source has no `branch' attribute")
     end
-    if not type(src.tag) == "string" then
+    if type(src.tag) ~= "string" then
         e:append("source has no `tag' attribute or tag attribute has wrong type")
     end
-    if not type(src.workingcopy_subdir) == "string" then
+    if type(src.workingcopy_subdir) ~= "string" then
         e2lib.warnf("WDEFAULT", "in source %s", sourcename)
         e2lib.warnf("WDEFAULT",
         " workingcopy_subdir defaults to the branch: %s", src.branch)