Replace chmod tool by function call and document it

Swap arguments to be the same as chmod(2)

Signed-off-by: Tobias Ulmer <tu@emlix.com>

diff --git a/generic/e2lib.lua b/generic/e2lib.lua
index 1c1c902cc7cd1cda4d5145d34690a0eab8cb486b..3a954b91f734ed9100b8873a11b92fde0a12d152 100644 (file)
--- a/generic/e2lib.lua
+++ b/generic/e2lib.lua
@@ -1982,14 +1982,26 @@ function e2lib.svn(argv)
     return e2lib.call_tool_argv("svn", argv)
 end
 
---- call the chmod command
--- @param mode string: the new mode
--- @param path string: path
--- @return bool
--- @return the last line ouf captured output
-function e2lib.chmod(mode, path)
-    local args = string.format("'%s' '%s'", mode, path)
-    return e2lib.call_tool("chmod", args)
+--- Change permission mode of file.
+-- @param path Path to file.
+-- @param mode Permission mode, may be "644" or "ugo+rwx" (string).
+-- @return True on success, false on error.
+-- @return Error object on failure.
+function e2lib.chmod(path, mode)
+    local rc, re, errstring, pmode
+
+    pmode, re = e2lib.parse_mode(mode)
+    if not pmode then
+        return false, re
+    end
+
+    rc, errstring = le2lib.chmod(path, pmode)
+    if not rc then
+        return false, err.new("changing permission mode on %q failed: %s",
+            path, errstring)
+    end
+
+    return true
 end
 
 --- Close all file descriptors equal or larger than "fd".